Put DataFileMetadata::as_record_batch under #[internal_api]
#1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
- Coverage 84.65% 84.65% -0.01%
==========================================
Files 115 115
Lines 29601 29597 -4
Branches 29601 29597 -4
==========================================
- Hits 25059 25055 -4
Misses 3331 3331
Partials 1211 1211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @zachschuermann @OussamaSaoudi to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
DataFileMetadata::as_record_batchto retry delta commits using the same uploaded parquet file (which is represented byDataFileMetadata).Can we please mark it with
internal_api?What changes are proposed in this pull request?
How was this change tested?